Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[client-hints] Test client hint availability in service workers" #25904

Merged
merged 1 commit into from Oct 1, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

This reverts commit 09255d96b70ea4f91e8219641476e8d0658d2fde.

Reason for revert: WPT bots on GitHub caught a possibly (probably) flaky test

https://github.com/web-platform-tests/wpt/pull/25845/checks?check_run_id=1187933269

Original change's description:

[client-hints] Test client hint availability in service workers

Change-Id: Icbb9de8fa340ac216a05a1093a1840c7903ba53c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432187
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812131}

TBR=yoavweiss@chromium.org,aarontag@chromium.org

Change-Id: I017b04cf0ba8b47e5fa271254f69816956397aed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441268
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812138}

This reverts commit 09255d96b70ea4f91e8219641476e8d0658d2fde.

Reason for revert: WPT bots on GitHub caught a possibly (probably) flaky test

https://github.com/web-platform-tests/wpt/pull/25845/checks?check_run_id=1187933269

Original change's description:
> [client-hints] Test client hint availability in service workers
>
> Change-Id: Icbb9de8fa340ac216a05a1093a1840c7903ba53c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432187
> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#812131}

TBR=yoavweiss@chromium.org,aarontag@chromium.org

Change-Id: I017b04cf0ba8b47e5fa271254f69816956397aed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441268
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812138}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 1621b70 into master Oct 1, 2020
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-678dd97f16 branch October 1, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants