Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethash: remove buildInputs #99187

Merged
merged 1 commit into from Oct 2, 2020
Merged

ethash: remove buildInputs #99187

merged 1 commit into from Oct 2, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

When reviewing #98054, I noticed that this package has a bunch of
buildInputs that are unused. There are no references to OpenCL, mesa,
boost, cryptopp, or openmpi in the source code. The package compiles
fine with these buildInputs removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
ethash: remove buildInputs
142a041 
When reviewing NixOS#98054, I noticed that this package has a bunch of
buildInputs that are unused. There are no references to OpenCL, mesa,
boost, cryptopp, or openmpi in the source code. The package compiles
fine with these buildInputs removed.
@AndersonTorres
Copy link
Member

Why the block comment PreConfigure?

@danieldk
Copy link
Contributor Author

danieldk commented Oct 1, 2020

Good question. I don't know this derivation. I guess the author wanted to keep the necessary steps around to make tests fork in principle?

@AndersonTorres
Copy link
Member

Well, I think it needs a cleanup after all.

@AndersonTorres AndersonTorres merged commit 672513d into NixOS:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @AndersonTorres