[FlexNG] Detect when a descendant's scrollbars change. #25901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 30, 2020
We currently have relayout logic to detect when a flex-items scrollbars change (to relayout) as this typically changes the min/max sizes. However this didn't account for an arbitrary descendant changing scrollbar state. This resulting in inconsistent sizes between a flexbox and a flex-item. Bug: 1127415 Change-Id: Ib2427f655437b1aa82dda2e0340fe950b079667f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424899 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#812389}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2424899
branch
from
bd66c6b
to
f7a2ee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have relayout logic to detect when a flex-items scrollbars
change (to relayout) as this typically changes the min/max sizes.
However this didn't account for an arbitrary descendant changing
scrollbar state. This resulting in inconsistent sizes between a flexbox
and a flex-item.
Bug: 1127415
Change-Id: Ib2427f655437b1aa82dda2e0340fe950b079667f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424899
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812389}