Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kicad: 5.1.6 -> 5.1.7 #99201

Closed
wants to merge 1 commit into from
Closed

kicad: 5.1.6 -> 5.1.7 #99201

wants to merge 1 commit into from

Conversation

evils
Copy link
Member

@evils evils commented Sep 30, 2020 •
edited

Motivation for this change

new stable release

Things done

bump stable version revisions to the latest release
remove kicad-ogltest binary handling since it's no longer in either stable or unstable

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    /nix/store/hdwswm6pjq1s006qki0h0p5yxdm2hjlx-kicad-small-5.1.6 1233494248
    /nix/store/rlr673dp6abqa7s02jx3va3xigcj529j-kicad-small-5.1.7 1230631960
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

i believe this does not conflict with any of the open PRs relevant to this package
(i have other changes to this package that do, which i will PR separately, which is why i'm not bumping kicad-unstable along with this update)

@ofborg ofborg bot requested review from Kiwi and berce September 30, 2020 22:13
@SuperSandro2000
Copy link
Member

@evils Can you solve the merge conflict?

@evils
Copy link
Member Author

evils commented Oct 23, 2020

@SuperSandro2000 done

quite annoying the favicon of this page keeps the green checkmark when there's a merge conflict...

i haven't built the resolved revision, though if it builds i wouldn't expect an application bug to be introduced by the change

@evils evils mentioned this pull request Nov 7, 2020
Merged
10 tasks
@evils evils deleted the kicad-5.1.7 branch January 8, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiwi Kiwi Awaiting requested review from Kiwi

@berce berce Awaiting requested review from berce

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evils @SuperSandro2000