Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luajit_2_0: 2.0.5-2020-08-09 -> 2.0.5-2020-09-27, luajit_2_1: 2.1.0-2020-08-27 -> 2.1.0-2020-09-30 #99227

Merged
merged 2 commits into from Oct 7, 2020
Merged

luajit_2_0: 2.0.5-2020-08-09 -> 2.0.5-2020-09-27, luajit_2_1: 2.1.0-2020-08-27 -> 2.1.0-2020-09-30 #99227

merged 2 commits into from Oct 7, 2020

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Oct 1, 2020

Motivation for this change
  • various fixes
  • support for full-range 64 bit lightuserdata, this mean we can safely enable GC64 on all platforms! (luajit_2_1)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lblasc lblasc requested a review from vcunat October 1, 2020 04:48
@ofborg ofborg bot added the 6.topic: lua label Oct 1, 2020
@ofborg ofborg bot requested review from grwlf, andir and thoughtpolice October 1, 2020 05:11
@vcunat
Copy link
Member

vcunat commented Oct 1, 2020

The second commit message is wrong (and the title). I was really happy for aarch64 yesterday when it happened. I'm not sure how well the upstream code has been tested, but I expect the update will be OK for nixpkgs master.

@lblasc lblasc changed the title luajit_2_0: 2.0.5-2020-08-09 -> 2.0.5-2020-09-27, luajit_2_1: 2.0.5-2020-08-27 -> 2.0.5-2020-09-30 luajit_2_0: 2.0.5-2020-08-09 -> 2.0.5-2020-09-27, luajit_2_1: 2.1.0-2020-08-27 -> 2.1.0-2020-09-30 Oct 1, 2020
@lblasc
Copy link
Contributor Author

lblasc commented Oct 1, 2020

Oops, fixed. Mike has good track record of pushing things which works and done right. I was also happy yesterday to see this finally solved.

vcunat
vcunat approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried some test suites; no errors found and some problems confirmed solved on aarch64. (There are some lua packages that still haven't added any workaround for that incompatibility.)

@ofborg ofborg bot requested a review from vcunat October 1, 2020 09:06
@vcunat vcunat merged commit c7b3d98 into NixOS:master Oct 7, 2020
@lblasc lblasc deleted the luajit-bump branch October 7, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grwlf grwlf Awaiting requested review from grwlf

@andir andir Awaiting requested review from andir

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lblasc @vcunat