Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openethereum: linux -> unix, remove systemd from buildInputs #99212

Merged
merged 1 commit into from Nov 11, 2020
Merged

openethereum: linux -> unix, remove systemd from buildInputs #99212

merged 1 commit into from Nov 11, 2020

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Oct 1, 2020 •
edited

Motivation for this change

openethereum don't build on macos.

Things done

remove the systemd dependency on mac, add darwin.Security dependency to fix link issue.

I'm not sure is the systemd dependency used at all, i don't have any issue to build on mac by removing it.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yihuang yihuang requested a review from mmahut as a code owner October 1, 2020 02:05
@yihuang yihuang marked this pull request as draft October 1, 2020 02:19
@yihuang
Copy link
Contributor Author

yihuang commented Oct 1, 2020 •
edited 

$ openethereum --config dev
2020-10-01 10:17:48  Starting OpenEthereum/v3.0.1-stable-UNKNOWN-UNKNOWN/x86_64-apple-darwin/rustc1.45.2
2020-10-01 10:17:48  Keys path $HOME/Library/Application Support/OpenEthereum/keys/DevelopmentChain
2020-10-01 10:17:48  DB path $HOME/Library/Application Support/OpenEthereum/chains/DevelopmentChain/db/1484bce8c021f2ca
2020-10-01 10:17:48  State DB configuration: fast
2020-10-01 10:17:48  Operating mode: active
[1]    78841 segmentation fault  openethereum --config dev

It crashes currently.

$ lldb ~/.nix-profile/bin/openethereum
(lldb) target create "$HOME.nix-profile/bin/openethereum"
Current executable set to '$HOME/.nix-profile/bin/openethereum' (x86_64).
(lldb) r --config dev
...
2020-10-01 10:22:06  State DB configuration: fast
2020-10-01 10:22:06  Operating mode: active
Process 79047 stopped
* thread #4, name = 'fetch', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x00000001027837e1 CoreFoundation`CFRetain + 17
CoreFoundation`CFRetain:
->  0x1027837e1 <+17>: ud2
    0x1027837e3 <+19>: nopw   %cs:(%rax,%rax)

CoreFoundation`_CFRuntimeInitStaticInstance:
    0x1027837f0 <+0>:  cmpq   $0x400, %rsi              ; imm = 0x400
    0x1027837f7 <+7>:  jae    0x10278384f               ; <+95>
Target 0: (openethereum) stopped.
(lldb) bt
* thread #4, name = 'fetch', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
  * frame #0: 0x00000001027837e1 CoreFoundation`CFRetain + 17
    frame #1: 0x0000000100873397 openethereum`hyper_rustls::connector::HttpsConnector$LT$hyper..client..connect..http..HttpConnector$GT$::new::hcace5d678ab16591 + 3639
    frame #2: 0x00000001007ee481 openethereum`std::sys_common::backtrace::__rust_begin_short_backtrace::ha37b8d5cd24e31f4 + 513
    frame #3: 0x00000001007c37e4 openethereum`core::ops::function::FnOnce::call_once$u7b$$u7b$vtable.shim$u7d$$u7d$::h4e7b97a4d3d23cf9 + 132
    frame #4: 0x000000010136c75d openethereum`std::sys::unix::thread::Thread::new::thread_start::hb19f90d9143f3795 + 45
    frame #5: 0x00007fff6ab95109 libsystem_pthread.dylib`_pthread_start + 148
    frame #6: 0x00007fff6ab90b8b libsystem_pthread.dylib`thread_start + 15

@ofborg ofborg bot requested a review from akru October 1, 2020 02:28
akru
akru approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@akru akru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

sbc64 pushed a commit to sbc64/nixpkgs that referenced this pull request Nov 11, 2020
Implement macOS build fix from NixOS#99212
15e80e6
@sbc64 sbc64 mentioned this pull request Nov 11, 2020
Merged
9 tasks
@mmahut mmahut merged commit 33de047 into NixOS:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akru akru akru approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@RaghavSood RaghavSood Awaiting requested review from RaghavSood RaghavSood will be requested when the pull request is marked ready for review RaghavSood is a code owner

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yihuang @akru @mmahut