Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mplayer: allow enabling v4l2 driver for e.g webcams #99210

Merged
merged 1 commit into from Nov 24, 2020
Merged

mplayer: allow enabling v4l2 driver for e.g webcams #99210

merged 1 commit into from Nov 24, 2020

Conversation

schmittlauch
Copy link
Member

Motivation for this change

I needed v4l2 support for being able to use MPlayer with my webcam.

  • add flag for enabling v4l2 support for the tv backend
  • required for some webcams
  • off by default as no other package seems to be relying on it so far

Whether the flag should default to true instead shall be decided by the package maintainers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch
mplayer: allow enabling v4l2 driver for e.g webcams
5204792 
- add flag for enabling v4l2 support for the tv backend
- required for some webcams
- off by default as no other package seems to be relying on it so far
@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build mplayer

@ofborg ofborg bot requested a review from edolstra October 1, 2020 01:13
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/314

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/381

@Mic92 Mic92 merged commit 4b610d8 into NixOS:master Nov 24, 2020
@schmittlauch schmittlauch deleted the mplayer-v4l branch November 24, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schmittlauch @nixos-discourse @SuperSandro2000 @Mic92