Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fractal: mark broken on Darwin #99195

Merged
merged 1 commit into from Nov 27, 2020
Merged

fractal: mark broken on Darwin #99195

merged 1 commit into from Nov 27, 2020

Conversation

berbiche
Copy link
Member

Motivation for this change

I tried building Fractal on a Darwin machine and the gspell dependency would not build on Darwin; therefore, Fractal does not build on Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

I see conditional compilation in the project so I believe it does support macos https://github.com/GNOME/gspell/blob/ab47e23883c59f36b70859f33639095704caa4e7/gspell/gspell-osx.c#L53 and it is documented in the README.md for fractal https://gitlab.gnome.org/GNOME/fractal/-/blob/master/README.md#macos. So I think the issue is that both gspell and and fractal are not built with darwin support in mind.

@berbiche
Copy link
Member Author

berbiche commented Sep 30, 2020 •
edited

I added darwin to the list of supported platforms to both gspell, libhandy and fractal.

One of the transitive dependencies of fractal makes it impossible to build on Darwin as it pulls in gnome-desktop.

@worldofpeace
Copy link
Contributor

I actually just built libhandy without gnome-desktop. I think the dependency there might be wrong. I don't expect you to add macos support (I will be removing gnome-desktop from libhandy now for GNOME 3.38), so maybe you can just add platforms.unix and mark it broken = stdenv.isDarwin;?

@berbiche berbiche changed the title fractal: restrict platforms to linux fractal: mark broken on Darwin Sep 30, 2020
@berbiche
Copy link
Member Author

@worldofpeace friendly ping

@SuperSandro2000 SuperSandro2000 merged commit 4c123fc into NixOS:master Nov 27, 2020
@mjlbach mjlbach mentioned this pull request Dec 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@berbiche @worldofpeace @SuperSandro2000