-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.pyelftools: 0.26 -> unstable-09-23 #99202
Conversation
@GrahamcOfBorg build esphome |
07e84d2
to
4dee2d3
Compare
Mmmh, I thought you proposition fixed it, but |
the whole explanation, platformio passes our packages to |
And fix the tests. Signed-off-by: Pamplemousse <xav.maso@gmail.com>
4dee2d3
to
bfa1a7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 99202 1
9 packages built:
- esphome
- platformio
- pwndbg
- pwntools (python38Packages.pwntools)
- python27Packages.pwntools
- python27Packages.pyelftools
- python37Packages.pwntools
- python37Packages.pyelftools
- python38Packages.pyelftools
@jonringer Thanks! For the record, I considered using the
So in the end, using a different version than their "hardcoded" one will probably trigger a lot of test failures. |
Because a latest version has been added to `nixpkgs`; See NixOS/nixpkgs#99202. Signed-off-by: Pamplemousse <xav.maso@gmail.com>
Motivation for this change
Last tagged version (dating from 12/2019) lack of several patches produced recently.
And run the tests!
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Ensured that relevant documentation is up to date