Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pyelftools: 0.26 -> unstable-09-23 #99202

Merged
merged 1 commit into from Oct 1, 2020
Merged

python3Packages.pyelftools: 0.26 -> unstable-09-23 #99202

merged 1 commit into from Oct 1, 2020

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

Last tagged version (dating from 12/2019) lack of several patches produced recently.
And run the tests!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build esphome

@Pamplemousse
Copy link
Member Author

Mmmh, I thought you proposition fixed it, but nixpkgs-review still shows failures for platformio and esphome...
Investigating it.

@jonringer
Copy link
Contributor

jonringer commented Oct 1, 2020 •
edited

the whole explanation, platformio passes our packages to mutliPkgs for buildFHSUserEnv, which means that a 32bit version is being built. However, the 32 vs 64 bit difference is causing it to fail in the scenario

@Pamplemousse
python3Packages.pyelftools: 0.26 -> unstable-09-23
bfa1a7d 
And fix the tests.

Signed-off-by: Pamplemousse <xav.maso@gmail.com>
jonringer
jonringer approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99202 1

9 packages built:
  • esphome
  • platformio
  • pwndbg
  • pwntools (python38Packages.pwntools)
  • python27Packages.pwntools
  • python27Packages.pyelftools
  • python37Packages.pwntools
  • python37Packages.pyelftools
  • python38Packages.pyelftools

@jonringer jonringer merged commit af27072 into NixOS:master Oct 1, 2020
@Pamplemousse
Copy link
Member Author

@jonringer Thanks!

For the record, I considered using the readelf from nixpkgs but here is a comment in the test file upstream:

Set the path for calling readelf. We carry our own version of readelf around, because binutils tend to change its output even between daily builds of the same minor release and keeping track is a headache.

https://github.com/eliben/pyelftools/blob/49ffaf4f956d87934bdf820284c313090a666720/test/run_readelf_tests.py#L31-L33

So in the end, using a different version than their "hardcoded" one will probably trigger a lot of test failures.

@Pamplemousse Pamplemousse deleted the pyelftools branch October 1, 2020 17:44
Pamplemousse added a commit to angr/nixpkgs that referenced this pull request Oct 1, 2020
@Pamplemousse
python3Packages.pyelftools: remove
4fdcd36 
Because a latest version has been added to `nixpkgs`;
See NixOS/nixpkgs#99202.

Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@siriobalmelli siriobalmelli mentioned this pull request Oct 15, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@igsha igsha Awaiting requested review from igsha

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pamplemousse @jonringer