Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

homeassistant: 0.114.4 -> 0.115.6 #99217

Merged
merged 1 commit into from Oct 2, 2020
Merged

homeassistant: 0.114.4 -> 0.115.6 #99217

merged 1 commit into from Oct 2, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 1, 2020

Motivation for this change

The image component is now part of the default_config dependency tree,
which is why we now require pillow by default.

The tests expect /usr to exist as their mymedia dir. That's not the case in our build environment, so patch it to and create /build/media.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from globin October 1, 2020 03:25
This was referenced Oct 1, 2020
Merged
Merged
@mweinelt
homeassistant: 0.114.4 -> 0.115.6
31d9bdf 
The image component is now part of the default_config dependency tree,
which is why we now require pillow by default.
@mweinelt
Copy link
Member Author

mweinelt commented Oct 2, 2020

@GrahamcOfBorg test home-assistant

@mweinelt mweinelt merged commit 9eeeb55 into NixOS:master Oct 2, 2020
@mweinelt mweinelt deleted the home-assistant branch October 2, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mweinelt