Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pillowfight: fix description #99218

Merged
merged 1 commit into from Oct 1, 2020
Merged

pythonPackages.pillowfight: fix description #99218

merged 1 commit into from Oct 1, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 1, 2020

Motivation for this change

Noticed the description of the package was off (a useless self-reference), while researching pillow related packages for home-assistant.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Oct 1, 2020
View reviewed changes
pkgs/development/python-modules/pillowfight/default.nix Outdated
@@ -16,7 +16,7 @@ buildPythonPackage rec {
propagatedBuildInputs = [ pillow ];

meta = with stdenv.lib; {
description = "Pillow Fight";
description = "Eases the transition from PIL to Pillow for Python packages.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://nixos.org/manual/nixpkgs/stable/#sec-standard-meta-attributes

Suggested change
description = "Eases the transition from PIL to Pillow for Python packages.";
description = "Eases the transition from PIL to Pillow for Python packages";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

jonringer
jonringer approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99218 1

@jonringer jonringer merged commit a9832e5 into NixOS:master Oct 1, 2020
@mweinelt mweinelt deleted the python/pillowfight branch October 1, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @jonringer