Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pygls: 0.9.0 -> 0.9.1 #99216

Merged
merged 1 commit into from Oct 1, 2020
Merged

pythonPackages.pygls: 0.9.0 -> 0.9.1 #99216

merged 1 commit into from Oct 1, 2020

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Oct 1, 2020 •
edited

Motivation for this change

Upgrade to the latest version: https://github.com/openlawlibrary/pygls/releases/tag/v0.9.1

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions

  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

    $ nix-env -f /home/kira/.cache/nixpkgs-review/rev-e4a70831a72f434b9d7bedf2bfbd21f5ed0f69c9/nixpkgs -qaP --xml --out-path --show-trace --meta
3 packages updated:
cmake-language-server python37Packages.pygls (0.9.0 → 0.9.1) python38Packages.pygls (0.9.0 → 0.9.1)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/kira/.cache/nixpkgs-review/rev-e4a70831a72f434b9d7bedf2bfbd21f5ed0f69c9/build.nix
3 packages built:
cmake-language-server python37Packages.pygls python38Packages.pygls

  • Tested execution of all binary files (usually in ./result/bin/)
    No binary files

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

mweinelt
mweinelt requested changes Oct 1, 2020
View reviewed changes
pkgs/development/python-modules/pygls/default.nix Outdated
@@ -1,30 +1,29 @@
{ stdenv, buildPythonPackage, isPy3k, fetchFromGitHub
, mock, pytest, pytest-asyncio
{ stdenv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of stdenv consume lib directly, you don't need stdenv anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've been asked to use stdenv.lib instead of just lib in previous code reviews, but I prefer using lib, so I will update it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe stdenv.lib is a copy/paste artifact, but someone more experienced may be able to clarify.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't just an artifact, I was explicitly asked to use stdenv.lib instead of just lib

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated my commit, but I'll leave this as unresolved if anyone else wants to leave comments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mweinelt IIRC, it was just a convenience to add lib to stdenv.

@mweinelt mweinelt mentioned this pull request Oct 1, 2020
Merged
10 tasks
@mweinelt
Copy link
Member

mweinelt commented Oct 1, 2020

Result of nixpkgs-review pr 99216 1

3 packages built:
  • cmake-language-server
  • python37Packages.pygls
  • python38Packages.pygls

jonringer
jonringer approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 99216 1

3 packages built:
  • cmake-language-server
  • python37Packages.pygls
  • python38Packages.pygls

@jonringer jonringer merged commit 0600273 into NixOS:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kira-bruneau @mweinelt @jonringer