Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: ad143c5b3b7e
Choose a base ref
...
head repository: NixOS/nix
compare: d761485010cc
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 6, 2020

  1. Prevent a deadlock when user namespace setup fails 

    Observed on Centos 7 when user namespaces are disabled:
DerivationGoal::startBuilder() throws an exception, ~DerivationGoal()
waits for the child process to exit, but the child process hangs
forever in drainFD(userNamespaceSync.readSide.get()) in
DerivationGoal::runChild(). Not sure why the SIGKILL doesn't get
through.

Issue #4092.
    @edolstra
    edolstra committed Oct 6, 2020
    Copy the full SHA
    d761485 View commit details
    Browse the repository at this point in the history