Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack: 4.9.0 -> 4.10.3 #99929

Merged
merged 1 commit into from Oct 31, 2020
Merged

slack: 4.9.0 -> 4.10.3 #99929

merged 1 commit into from Oct 31, 2020

Conversation

JesusMtnez
Copy link
Contributor

@JesusMtnez JesusMtnez commented Oct 7, 2020

Motivation for this change

Bump Slack to latest release: 4.10.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Oct 7, 2020

can you please bump all of them?

@JesusMtnez
Copy link
Contributor Author

JesusMtnez commented Oct 8, 2020

can you please bump all of them?

There is no release for Linux yet, it is only MacOS

@JesusMtnez
Copy link
Contributor Author

@mmahut They have just released 4.10.0 for Linux too. I just updated the PR to update both 👍

@mmahut
Copy link
Member

mmahut commented Oct 20, 2020

Thank you!

@GrahamcOfBorg eval

@JesusMtnez
Copy link
Contributor Author

@mmahut version 4.10.3 is available. Do you want me to update this PR or open a new one?

@JesusMtnez JesusMtnez changed the title slack: 4.9.0 -> 4.10.0 slack: 4.9.0 -> 4.10.3 Oct 20, 2020
@JesusMtnez
Copy link
Contributor Author

@mmahut I just updated this PR to the latest 4.10.3 version

@mmahut
Copy link
Member

mmahut commented Oct 20, 2020

You rock.

@GrahamcOfBorg build slack

@JesusMtnez
Copy link
Contributor Author

@GrahamcOfBorg build slack

@mmahut mmahut merged commit 7bea6f9 into NixOS:master Oct 31, 2020
@JesusMtnez JesusMtnez deleted the slack branch October 31, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants