Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter: Bump and add dart cache to flutter #99920

Merged
merged 1 commit into from Oct 30, 2020
Merged

flutter: Bump and add dart cache to flutter #99920

merged 1 commit into from Oct 30, 2020

Conversation

ericdallo
Copy link
Member

@ericdallo ericdallo commented Oct 7, 2020 •
edited

Motivation for this change
  • Flutter requires dart-sdk cache to work propertly
  • bump flutter version to latest

Fixes #98405

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from babariviere October 7, 2020 03:08
babariviere
babariviere reviewed Oct 7, 2020
View reviewed changes
pkgs/development/compilers/flutter/default.nix Outdated
Comment on lines 23 to 24
channel = "stable";
version = "1.22.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be beta instead of stable? Latest beta version is 1.22.0-12.3.pre

Copy link
Member Author

@ericdallo ericdallo Oct 7, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, For some reason when I run flutter --version from beta channel it returns exactly the same for stable. But checking the git version of flutter repo, I think you are right, done!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take a look again @babariviere ?

@ericdallo ericdallo force-pushed the add-dart-to-flutter branch 2 times, most recently from 54377b9 to cadfab0 Compare October 7, 2020 12:39
@ericdallo ericdallo mentioned this pull request Oct 7, 2020
Closed
@ofborg ofborg bot requested a review from babariviere October 7, 2020 12:50
babariviere
babariviere approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@babariviere babariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericdallo
Copy link
Member Author

@danieldk or @worldofpeace could you please merge?

@NANASHI0X74 NANASHI0X74 mentioned this pull request Oct 20, 2020
Closed
@storvik
Copy link
Member

storvik commented Oct 21, 2020

Just tested this with Nix and Ubuntu. Flutter and dart development tools seems to be working as expected 👍

@ericdallo
Copy link
Member Author

@jonringer maybe you can help us merging that?

@ericdallo
Copy link
Member Author

@marsam ?

@ofborg ofborg bot requested a review from babariviere October 30, 2020 13:22
@marsam marsam merged commit e250fef into NixOS:master Oct 30, 2020
@ericdallo ericdallo deleted the add-dart-to-flutter branch October 31, 2020 03:07
@ericdallo
Copy link
Member Author

Thank you @marsam ❤️

@jtacoma jtacoma mentioned this pull request Dec 29, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@thiagokokada thiagokokada thiagokokada approved these changes

@babariviere babariviere Awaiting requested review from babariviere

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should dart and cache be made available when installing Flutter?
5 participants
@ericdallo @storvik @marsam @thiagokokada @babariviere