New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbreak haskellPackages.hpack-dhall #99926
Conversation
0f88449
to
74e58a6
Compare
74e58a6
to
580ab28
Compare
# Test suite fails due golden tests checking text representation | ||
# of normalized dhall expressions, and newer dhall versions format | ||
# differently. | ||
hpack-dhall = dontCheck super.hpack-dhall; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something you could report upstream?
If so, please create an issue upstream, and link to it here in this commit right above the hpack-dhall =
line.
We like to be able to have some way of tracking when these uses of dontCheck
can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already in master, but not in release: cabalism/hpack-dhall@5049aa4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Can you add an assert on hpack-dhall.version with a comment to remove the dontCheck, when the assert fails?
be2e4fb
to
1436509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, this PR is pretty uncontroversial, but I can‘t really judge it before a rebase.
580ab28
to
c293492
Compare
@maralorn @cdepillabout Rebases, fixed merge conflicts, found at which commit upstream already fixed problem. We will be able to drop override on next upstream release. Should I create issue about it? |
# Test suite fails due golden tests checking text representation | ||
# of normalized dhall expressions, and newer dhall versions format | ||
# differently. | ||
hpack-dhall = dontCheck super.hpack-dhall; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Can you add an assert on hpack-dhall.version with a comment to remove the dontCheck, when the assert fails?
c293492
to
8c5302f
Compare
Beautiful! @GrahamcOfBorg build haskellPackages.hpack-dhall Ready to merge, when test passes. |
@maralorn ofBorg seems to be unhappy, but it complains about pandoc, which seems to be unrelated. |
Yeah, someone should fix that … I meant to do that the last two days … Anyways I'll quickly do the build locally. |
Checked build locally. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)