Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support name attribute in fetchGit #4116

Closed
wants to merge 1 commit into from
Closed

support name attribute in fetchGit #4116

wants to merge 1 commit into from

Conversation

AmineChikhaoui
Copy link
Member

I think this was accidentally removed during the refactoring of
fetch{Tree,Git} which introduced issues such as:

unsupported Git input attribute 'name'

@AmineChikhaoui
support name attribute in fetchGit
f457758 
I think this was accidentally removed during the refactoring of
fetch{Tree,Git} which introduced issues such as:

```
unsupported Git input attribute 'name'
```
@AmineChikhaoui
Copy link
Member Author

I'm not sure the failures in the checks are false positives or not.

@AmineChikhaoui
Copy link
Member Author

@edolstra does this look good to you ?

@AmineChikhaoui
Copy link
Member Author

@edolstra would you mind just adding the simple change name != "name" so that fetchGit would support name as attribute ?

@AmineChikhaoui AmineChikhaoui deleted the fetchgit-name branch January 1, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AmineChikhaoui