Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/murmur: add option environmentFile for injecting secrets #99934

Merged
merged 1 commit into from Oct 7, 2020
Merged

nixos/murmur: add option environmentFile for injecting secrets #99934

merged 1 commit into from Oct 7, 2020

Conversation

elseym
Copy link
Member

@elseym elseym commented Oct 7, 2020

Secrets are injected from the environment into the rendered
configuration before each startup using envsubst.
The test now makes use of this feature for the server password.

Motivation for this change

Add the ability to pass secrets to the service without adding them to the Nix store.

analogous to #98550 and #97371

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elseym elseym requested a review from lheckemann October 7, 2020 09:40
@elseym
Copy link
Member Author

elseym commented Oct 7, 2020

@GrahamcOfBorg test mumble

@elseym
nixos/murmur: add option environmentFile for injecting secrets
533560d 
Secrets are injected from the environment into the rendered
configuration before each startup using envsubst.
The test now makes use of this feature for the server password.
@lheckemann lheckemann merged commit 8e2796d into NixOS:master Oct 7, 2020
@lheckemann lheckemann deleted the murmur-env branch October 7, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann approved these changes

@dasJ dasJ dasJ approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elseym @lheckemann @dasJ