Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages_5_7: added ext4 swap fix patch to the kernel #99915

Closed
wants to merge 1 commit into from
Closed

linuxPackages_5_7: added ext4 swap fix patch to the kernel #99915

wants to merge 1 commit into from

Conversation

BK1603
Copy link

@BK1603 BK1603 commented Oct 7, 2020

Motivation for this change

Fix for #91986

Applies a patch that fixes the kernel bug wherein the swap fails as the kernel falsely detects holes in the swap files allocated using fallocate.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@BK1603 BK1603 mentioned this pull request Oct 10, 2020
Closed
@BK1603
Copy link
Author

BK1603 commented Oct 10, 2020

@jtojnar, just a ping to notify you about the PR. Review whenever you can find the time.

@NeQuissimus
Copy link
Member

Is this relevant to the 5.8 kernel series? I am about to remove 5.7 from mastersince it has been EOL'd

@BK1603
Copy link
Author

BK1603 commented Oct 12, 2020 •
edited

There exists this bug, but I don't know if the same patch would fix it.

EDIT: I think this has been fixed in the kernel itself? Here is the merge request. Also I see no other reports for this bug. The 5.7 was reported a lot more times and at a lot of places, (say the arch forums apart from the ubuntu bugs and the kernel mailing list.)

EDIT2: Just updated to 5.8 and allocating a swapfile using fallocate and using it for swap works.

@NeQuissimus
Copy link
Member

👍 So as per "EDIT2" this is only relevant to 5.7? I think we can close this then? What do you think?

@BK1603
Copy link
Author

BK1603 commented Oct 14, 2020

Yes, I think it's safe to close this for now then. I am pretty sure this isn't relevant to 5.8, and in the worst case, even if it is, and we do get issues reported for that kernel version, I'll help with it again :)

@BK1603 BK1603 closed this Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BK1603 @NeQuissimus @Janik-Haag