-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow arguments other than Time in FFT #2752
Conversation
class FastFourierTransform { | ||
public: | ||
using AngularFrequency = Derivative<Angle, Argument>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document that this is only a bona fide angular frequency if Argument
is time-like.
private: | ||
Time const Δt_; | ||
Difference<Argument> const Δt_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document that this is only a bona fide time if Argument
is time-like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what the type says (and the word time does not appear anyway).
std::array<Voltage, n> u{{1 * Volt, 0 * Volt, 1 * Volt, 0 * Volt}}; | ||
FastFourierTransform<Voltage, Instant, n> const U(u, Δt); | ||
|
||
FastFourierTransform<Voltage, AngularFrequency, n> const nu( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Greek nu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is n times u. Renamed u to v for clarity.
retest this please |
This will be used in Clenshaw-Curtis, which in turn will be used to compute the inner products and norms in the Modified Gram-Schmidt introduced by #2750, continuing the inexorable progress towards #2400.