Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-re2: init at 0.1.20210601 #99938

Merged
merged 2 commits into from Jun 12, 2021
Merged

google-re2: init at 0.1.20210601 #99938

merged 2 commits into from Jun 12, 2021

Conversation

alexbakker
Copy link
Member

Motivation for this change

New package. Depends on #99647.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alexbakker
Copy link
Member Author

#99647 was merged.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 27, 2020 •
edited

Result of nixpkgs-review pr 99938 run on x86_64-linux 1

1 package failed to build:
  • python27Packages.google-re2
2 packages built:
  • python37Packages.google-re2
  • python38Packages.google-re2
 ERROR: Package 'google-re2' requires a different Python: 2.7.18 not in '~=3.6'

@alexbakker alexbakker changed the title google-re2: init at 0.0.7 google-re2: init at 0.1.20210601 Jun 9, 2021
@alexbakker
Copy link
Member Author

Apologies for the extremely long delay.

@SuperSandro2000 I resolved the merge conflict and bumped the version to the latest (0.1.20210601). I'm not sure if the Python 2 build failure is still a problem, as I don't think hydra still builds that set anymore anyway. But if it is a problem, how should I go about excluding Python 2 for this package?

@SuperSandro2000
Copy link
Member

Apologies for the extremely long delay.

@SuperSandro2000 I resolved the merge conflict and bumped the version to the latest (0.1.20210601). I'm not sure if the Python 2 build failure is still a problem, as I don't think hydra still builds that set anymore anyway. But if it is a problem, how should I go about excluding Python 2 for this package?

It is excluded now. You can disable certain versions with disabled = pythonAtLeast "3.6".

@alexbakker
Copy link
Member Author

alexbakker commented Jun 9, 2021 •
edited

Thanks, addressed both comments.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 99938 run on x86_64-linux 1

2 packages built:
  • python38Packages.google-re2
  • python39Packages.google-re2

@SuperSandro2000 SuperSandro2000 merged commit 222dcb8 into NixOS:master Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexbakker @SuperSandro2000