Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcyaml: init at 1.1.0 #98872

Merged
merged 1 commit into from Feb 10, 2021
Merged

libcyaml: init at 1.1.0 #98872

merged 1 commit into from Feb 10, 2021

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Sep 26, 2020

Motivation for this change

A part of #98871.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 9, 2021 •
edited

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 98872 run on x86_64-darwin 1

1 package failed to build and already failed to build on hydra master: 
builder for '/nix/store/kly7k84mzclcaffvwpyfhw7mgb1i11fh-libcyaml-1.1.0.drv' failed with exit code 2; last 10 log lines:
  clang -I include -DVERSION_MAJOR=1 -DVERSION_MINOR=1 -DVERSION_PATCH=0 -DVERSION_DEVEL=0  -std=c11 -Wall -Wextra -pedantic -Wconversion -O2 -DNDEBUG -fPIC  -c -o build/release/shared/src/mem.o src/mem.c
  clang -I include -DVERSION_MAJOR=1 -DVERSION_MINOR=1 -DVERSION_PATCH=0 -DVERSION_DEVEL=0  -std=c11 -Wall -Wextra -pedantic -Wconversion -O2 -DNDEBUG -fPIC  -c -o build/release/shared/src/free.o src/free.c
  clang -I include -DVERSION_MAJOR=1 -DVERSION_MINOR=1 -DVERSION_PATCH=0 -DVERSION_DEVEL=0  -std=c11 -Wall -Wextra -pedantic -Wconversion -O2 -DNDEBUG -fPIC  -c -o build/release/shared/src/load.o src/load.c
  clang -I include -DVERSION_MAJOR=1 -DVERSION_MINOR=1 -DVERSION_PATCH=0 -DVERSION_DEVEL=0  -std=c11 -Wall -Wextra -pedantic -Wconversion -O2 -DNDEBUG -fPIC  -c -o build/release/shared/src/save.o src/save.c
  clang -I include -DVERSION_MAJOR=1 -DVERSION_MINOR=1 -DVERSION_PATCH=0 -DVERSION_DEVEL=0  -std=c11 -Wall -Wextra -pedantic -Wconversion -O2 -DNDEBUG -fPIC  -c -o build/release/shared/src/util.o src/util.c
  clang -I include -DVERSION_MAJOR=1 -DVERSION_MINOR=1 -DVERSION_PATCH=0 -DVERSION_DEVEL=0  -std=c11 -Wall -Wextra -pedantic -Wconversion -O2 -DNDEBUG -fPIC  -c -o build/release/shared/src/utf8.o src/utf8.c
  clang -o build/release/libcyaml.so.1 build/release/shared/src/mem.o build/release/shared/src/free.o build/release/shared/src/load.o build/release/shared/src/save.o build/release/shared/src/util.o build/release/shared/src/utf8.o -lyaml  -Wl,-soname=libcyaml.so.1 -shared
  ld: unknown option: -soname=libcyaml.so.1
  clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
  make: *** [Makefile:130: build/release/libcyaml.so.1] Error 1

@SuperSandro2000 SuperSandro2000 merged commit cc0da25 into NixOS:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suhr @SuperSandro2000