Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: 4.12.5 -> 4.12.6, fix build on darwin #98877

Merged
merged 1 commit into from Sep 26, 2020
Merged

samba: 4.12.5 -> 4.12.6, fix build on darwin #98877

merged 1 commit into from Sep 26, 2020

Conversation

r-burns
Copy link
Contributor

@r-burns r-burns commented Sep 26, 2020

Upstream commit https://gitlab.com/samba-team/devel/samba/-/commit/6e263432
fixes compilation on BSD/macOS.

Motivation for this change

ZHF 20.09 #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 26, 2020
@ofborg ofborg bot requested a review from aneeshusa September 26, 2020 18:50
@risicle
Copy link
Contributor

risicle commented Sep 26, 2020

Builds for me macos 10.14

@risicle
Copy link
Contributor

risicle commented Sep 26, 2020

@ofborg build smbclient python37Packages.pysmbc smbnetfs gvfs

@risicle risicle merged commit 6735048 into NixOS:master Sep 26, 2020
@risicle risicle added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 26, 2020
@r-burns r-burns mentioned this pull request Sep 26, 2020
Merged
10 tasks
@r-burns r-burns deleted the samba branch September 27, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneeshusa aneeshusa Awaiting requested review from aneeshusa

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-burns @risicle