New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpd: 0.21.25 -> 0.22 #98869
mpd: 0.21.25 -> 0.22 #98869
Conversation
b050b96
to
a6aae7b
Compare
MPD now builds with liburing support, so I expect ofborg's MPD NixOS tests to pass. |
@doronbehar I don't have anything to add here. |
Oh sorry for keeping us waiting :) I was hoping to get your approval on my changes but I wasn't clear. |
Also @thoughtpolice doesn't express any objection, so I think this is good to go. |
pkgs/servers/mpd/default.nix
Outdated
@@ -193,7 +197,7 @@ in | |||
"yajl" "sqlite" | |||
"soundcloud" "qobuz" "tidal" | |||
] ++ lib.optionals stdenv.isLinux [ | |||
"alsa" "systemd" "syslog" | |||
"alsa" "systemd" "syslog" /*"io_uring"*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lucky I got thorough it once more, this needs to be uncommented.
a6aae7b
to
bee9b63
Compare
Experienced in: NixOS#98869 (comment) Set configure flags properly, don't override configurePhase, per: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/explicit-phases.md Use different output names - use $bin for examples, and $out for libraries which expectedly should be referenced by reverse deps.
bee9b63
to
ac5e227
Compare
This push fixed a typo in commit message. |
This broke cross compilation of liburing, see #101810 for a fix. |
Motivation for this change
New version: https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/v0.22/NEWS
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Closure size grows from 483.1 to 483.2 Mb.