buildbot: 2.8.2 -> 2.8.4 #96033
Merged
buildbot: 2.8.2 -> 2.8.4 #96033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Aug 23, 2020
There was a problem hiding this comment.
looks like python38 is failing:
https://github.com/NixOS/nixpkgs/pull/96033
3 packages failed to build:
buildbot buildbot-full buildbot-ui
17 packages built:
buildbot-worker python37Packages.buildbot python37Packages.buildbot-full python37Packages.buildbot-pkg python37Packages.buildbot-plugins.console-view python37Packages.buildbot-plugins.grid-view python37Packages.buildbot-plugins.waterfall-view python37Packages.buildbot-plugins.wsgi-dashboards python37Packages.buildbot-plugins.www python37Packages.buildbot-ui python37Packages.buildbot-worker python38Packages.buildbot-pkg python38Packages.buildbot-plugins.console-view python38Packages.buildbot-plugins.grid-view python38Packages.buildbot-plugins.waterfall-view python38Packages.buildbot-plugins.wsgi-dashboards python38Packages.buildbot-plugins.www
perhaps skip some of the integration tests?
[ERROR]
Traceback (most recent call last):
Failure: twisted.internet.defer.TimeoutError: <buildbot.test.integration.test_try_client.Schedulers testMethod=test_userpass_wait> (test_userpass_wait) still running at 5.0 secs
buildbot.test.integration.test_try_client.Schedulers.test_userpass_wait
===============================================================================
[ERROR]
Traceback (most recent call last):
File "/nix/store/gzm77ld3mxzkgrx7lhlnlscpwhkndphf-python3.8-Twisted-20.3.0/lib/python3.8/site-packages/twisted/trial/util.py", line 276, in _runSequentially
thing = yield d
File "/nix/store/gzm77ld3mxzkgrx7lhlnlscpwhkndphf-python3.8-Twisted-20.3.0/lib/python3.8/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
result = g.send(result)
File "/build/buildbot-2.8.3/buildbot/test/util/integration.py", line 209, in dump
raise self.failureException(dump.getvalue())
twisted.trial.unittest.FailTest: FAILED! dumping build db for debug
*** BUILD 1 *** ==> build successful (success)
*** STEP worker_preparation *** ==> worker ready (success)
*** STEP one *** ==> finished (success)
*** STEP two *** ==> finished (success)
buildbot.test.integration.test_try_client.Schedulers.test_userpass_wait
===============================================================================
[ERROR]
Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 0x7fffdbf752b0 [1.0346012115478516s] called=0 cancelled=0 LoopingCall<3>(Schedulers.setUp.<locals>.<lambda>, *(), **{})()>
buildbot.test.integration.test_try_client.Schedulers.test_userpass_wait
===============================================================================
[ERROR]
Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
Selectables:
<<class 'twisted.internet.tcp.Client'> to ('127.0.0.1', 38085) at 7fffdad4ff10>
<Broker #0 on 38085>
buildbot.test.integration.test_try_client.Schedulers.test_userpass_wait
-------------------------------------------------------------------------------
Ran 5776 tests in 84.409
|
I can't reproduce that failure, and neither can ofborg. |
|
must be my 32 core count then |
|
@GrahamcOfBorg test buildbot |
|
I made an issue with the tests #96197 . They aren't specific to buildbot, but rather all nixosTests are broken right now. I commented out the offending lines and was able to run the tests though. |
jonringer
approved these changes
Aug 24, 2020
lopsided98
force-pushed
the
buildbot-update
branch
from
ad9af49
to
9422dd7
Compare
|
I updated this PR to 2.8.4. |
jonringer
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 96033 1
20 packages built:
- buildbot (python38Packages.buildbot)
- buildbot-full (python38Packages.buildbot-full)
- buildbot-ui (python38Packages.buildbot-ui)
- buildbot-worker (python38Packages.buildbot-worker)
- python37Packages.buildbot
- python37Packages.buildbot-full
- python37Packages.buildbot-pkg
- python37Packages.buildbot-plugins.console-view
- python37Packages.buildbot-plugins.grid-view
- python37Packages.buildbot-plugins.waterfall-view
- python37Packages.buildbot-plugins.wsgi-dashboards
- python37Packages.buildbot-plugins.www
- python37Packages.buildbot-ui
- python37Packages.buildbot-worker
- python38Packages.buildbot-pkg
- python38Packages.buildbot-plugins.console-view
- python38Packages.buildbot-plugins.grid-view
- python38Packages.buildbot-plugins.waterfall-view
- python38Packages.buildbot-plugins.wsgi-dashboards
- python38Packages.buildbot-plugins.www
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updates buildbot to the latest version. The SQLAlchemy fix patch has not been backported to the 2.8 branch, so we still need it.
cc @nand0p @ryansydnor
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)