Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python38Packages.coloredlogs: disable tests on darwin #96037

Merged
merged 1 commit into from Jan 24, 2021
Merged

python38Packages.coloredlogs: disable tests on darwin #96037

merged 1 commit into from Jan 24, 2021

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Aug 22, 2020

Fixing the build on darwin / py38 by turning capturer and verboselogs into checkInputs and disabling the test for this combo.
This can be reverted after xolox/python-capturer#10 is fixed.

See

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Aug 23, 2020
@ofborg ofborg bot requested a review from eyJhb August 23, 2020 00:29
jonringer
jonringer reviewed Aug 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

This can be done with:

git reset HEAD~1                    # move fix-up commits into unstaged
git add -- pkgs/                    # move changes into staged
git commit --amend --no-edit        # add changes to previous commit
git push ... ... --force            # modify current PR branch

@tobim tobim force-pushed the python38Packages/fix-coloredlogs-darwin branch from a172866 to 18d1a80 Compare August 24, 2020 12:03
@tobim
Copy link
Contributor Author

tobim commented Aug 24, 2020

@jonringer done.

@SuperSandro2000
Copy link
Member

@tobim Please fix the merge conflict.

@tobim tobim force-pushed the python38Packages/fix-coloredlogs-darwin branch from d605d30 to 5cf8a80 Compare January 23, 2021 11:38
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 96037 run on x86_64-linux 1

19 packages built:
  • coloredlogs (python38Packages.coloredlogs)
  • executor (python38Packages.executor)
  • ocrmypdf
  • python37Packages.coloredlogs
  • python37Packages.executor
  • python37Packages.property-manager
  • python37Packages.rotate-backups
  • python37Packages.update-dotdee
  • python37Packages.zigpy-znp
  • python38Packages.property-manager
  • rotate-backups (python38Packages.rotate-backups)
  • update-dotdee (python38Packages.update-dotdee)
  • python38Packages.zigpy-znp
  • python39Packages.coloredlogs
  • python39Packages.executor
  • python39Packages.property-manager
  • python39Packages.rotate-backups
  • python39Packages.update-dotdee
  • python39Packages.zigpy-znp

jonringer
jonringer approved these changes Jan 24, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

leave darwin verification to @SuperSandro2000

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 24, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 96037 run on x86_64-darwin 1

10 packages failed to build and are new build failures:
  • python37Packages.coloredlogs: log https://termbin.com/mj6c
  • python37Packages.executor: log was empty
  • python37Packages.property-manager: log was empty
  • python37Packages.rotate-backups: log was empty
  • python37Packages.update-dotdee: log was empty
  • python39Packages.coloredlogs: log was empty
  • python39Packages.executor: log was empty
  • python39Packages.property-manager: log was empty
  • python39Packages.rotate-backups: log was empty
  • python39Packages.update-dotdee: log was empty
5 packages built:
  • coloredlogs (python38Packages.coloredlogs)
  • executor (python38Packages.executor)
  • python38Packages.property-manager
  • rotate-backups (python38Packages.rotate-backups)
  • update-dotdee (python38Packages.update-dotdee)

I think I needed to kill something in that nixpkgs-review because it hang for hours.

@jonringer jonringer merged commit 829d84d into NixOS:master Jan 24, 2021
@tobim tobim deleted the python38Packages/fix-coloredlogs-darwin branch August 1, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@eyJhb eyJhb Awaiting requested review from eyJhb

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobim @SuperSandro2000 @jonringer