Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: protonmail-bridge: 1.2.3-1 -> 1.3.3-1 #96036

Closed
wants to merge 1 commit into from
Closed

WIP: protonmail-bridge: 1.2.3-1 -> 1.3.3-1 #96036

wants to merge 1 commit into from

Conversation

CloudArtAdmins
Copy link
Contributor

Updating protonmail bridge.
Current error is that a .desktop file is missing.
Uncertain what it is, but starting the PR, if anyone is more familiar.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CloudArtAdmins CloudArtAdmins changed the title WIP: protonvpn-bridge: 1.2.3-1 -> 1.3.3-1 WIP: protonmail-bridge: 1.2.3-1 -> 1.3.3-1 Aug 22, 2020
@CloudArtAdmins
Copy link
Contributor Author

Not sure why, but it appears to be building and running with qt 5.12, still. Despite qtbase being 5.14.

@ofborg ofborg bot requested a review from lightdiscord August 23, 2020 01:44
@lightdiscord
Copy link
Member

lightdiscord commented Aug 23, 2020 •
edited

Not sure why, but it appears to be building and running with qt 5.12, still. Despite qtbase being 5.14.

protonmail-bridge is called using libsForQt512.callPackage in pkgs/top-level/all-packages.nix. You need to replace it with libsForQt5 or libsForQt514.

But I thought they were using qt 5.13 so I don't know if it will work with 5.14.

@CloudArtAdmins
Copy link
Contributor Author

You may be right.
I'm not familiar with Qt.
results/protonmail-bridge/bin/protonmail-bridge: symbol lookup error: results/protonmail-bridge/bin/protonmail-bridge: undefined symbol: _ZdlPvm, version Qt_5
It does run, at least, just need to find out if this is something new in the package or because the version needs to be 5.13.

@CloudArtAdmins
WIP: protonvpn-bridge: 1.2.3-1 -> 1.3.3-1
28988b0 
Updating protonmail bridge.
Current error is that a .desktop file is missing.
Uncertain what it is, but starting the PR, if anyone is more familiar.

.desktop file changed case

Changing the name again

fixed _ error

changing version of qt512 to qt5
@ryantm ryantm marked this pull request as draft October 23, 2020 02:59
@jezcope
Copy link
Contributor

jezcope commented Nov 6, 2020

Proton have released the source for the bridge now at https://github.com/ProtonMail/proton-bridge, so it might be more maintainable to switch to building from source now? Also, the released version is up to 1.4.5-1 now (they move quickly!)

@lightdiscord
Copy link
Member

lightdiscord commented Nov 6, 2020 •
edited

As discussed in #97991 we should work on a limited cli version. I'm looking into this as soon as I've some free time 😅

EDIT: I managed to build it and make it work locally, I will soon make a draft PR.
EDIT 2: The PR is available here #103037

@CloudArtAdmins
Copy link
Contributor Author

Hey, just so you guys know and aren't expecting, I haven't been using Nix enough recently to make time to figure the rest of this out.
Just letting you all know in the event someone is thinking of fixing this but doesn't cause I made the request.
Sorry.

@prusnak
Copy link
Member

prusnak commented Nov 23, 2020

Let's close this in favor of #103037

@prusnak prusnak closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightdiscord lightdiscord Awaiting requested review from lightdiscord

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CloudArtAdmins @lightdiscord @jezcope @prusnak