signal-desktop: Add optional libdbusmenu-glib support #96078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@primeos Pull req created |
primeos
requested changes
Aug 23, 2020
There was a problem hiding this comment.
Are you using this on Ubuntu? From Electron's source-code comments this should only be required for Unity, but if it affects other environments as well we could enable it by default.
Edit:
libdbusmenu support is needed in some cases - eg. when using appmenu on Plasma/Xfce/Cinnamon or Budgie.
Nvm, feel free to enable this by default (i.e. without enableLibdbusmenuSupport) if it also helps/works on "Plasma/Xfce/Cinnamon or Budgie".
pkgs/applications/networking/instant-messengers/signal-desktop/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/signal-desktop/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/networking/instant-messengers/signal-desktop/default.nix
Outdated
Show resolved
Hide resolved
LouisDK1
force-pushed
the
signal-desktop_libdbusmenu-glib
branch
from
660d554
to
cb20617
Compare
Provides optional menu bar support for various desktop environments.
primeos
force-pushed
the
signal-desktop_libdbusmenu-glib
branch
from
cb20617
to
0fec62c
Compare
|
Ok, so I just updated the PR to how I visioned that, could you try if that still works as expected? |
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
|
It works as expected. Appmenu is supported under Plasma without overwriting anything. Thanks for your assistance. I'd say it's ready to merge. |
10 tasks
This was referenced Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
libdbusmenu support is needed in some cases - eg. when using appmenu on Plasma/Xfce/Cinnamon or Budgie.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)