Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdt: init at 1.3.3 #96038

Merged
merged 1 commit into from Aug 24, 2020
Merged

hdt: init at 1.3.3 #96038

merged 1 commit into from Aug 24, 2020

Conversation

koslambrou
Copy link
Contributor

Added the hdt package in Nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Closes: #94670

@koslambrou koslambrou mentioned this pull request Aug 22, 2020
Closed
10 tasks
peterhoeg
peterhoeg requested changes Aug 22, 2020
View reviewed changes
pkgs/misc/hdt/default.nix Outdated Show resolved Hide resolved
pkgs/misc/hdt/default.nix Outdated Show resolved Hide resolved
pkgs/misc/hdt/default.nix Outdated Show resolved Hide resolved
pkgs/misc/hdt/default.nix Outdated Show resolved Hide resolved
pkgs/misc/hdt/default.nix Outdated Show resolved Hide resolved
@peterhoeg
Copy link
Member

I just realized that this is your first PR, so let me take this opportunity to welcome you here and say "thank you" for contributing.

Feel free to ask if you have any questions about any of this.

@koslambrou
Copy link
Contributor Author

@peterhoeg Thanks for the PR review. Glad to contribute: :)
The proposed changes were applied

@peterhoeg
Copy link
Member

One last thing, sorry. Please add enableParallelBuilding = true; as it will make it build in about half the time.

@koslambrou
Copy link
Contributor Author

@peterhoeg done!

@peterhoeg peterhoeg merged commit 6072bac into NixOS:master Aug 24, 2020
@koslambrou koslambrou deleted the add-hdt-package branch August 24, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging request : hdt
2 participants
@koslambrou @peterhoeg