Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: disable cephfs on aarch64 #96085

Merged
merged 1 commit into from Aug 24, 2020
Merged

samba: disable cephfs on aarch64 #96085

merged 1 commit into from Aug 24, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 23, 2020

not supported there.

Not yet tested, Let's see what ofborg says.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
samba: disable cephfs on aarch64
2647686 
not supported there.
@Mic92
Copy link
Member Author

Mic92 commented Aug 23, 2020

@GrahamcOfBorg build sambaFull

danieldk
danieldk approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ofborg seems to be happy

@danieldk danieldk merged commit c557ea5 into NixOS:master Aug 24, 2020
@Mic92 Mic92 deleted the samba-aarch64 branch August 26, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @danieldk