Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

z-lua: reveal bin name z to z.lua #96081

Merged
merged 1 commit into from Dec 23, 2020
Merged

z-lua: reveal bin name z to z.lua #96081

merged 1 commit into from Dec 23, 2020

Conversation

holymonson
Copy link
Contributor

According to document, user should call eval "$(z.lua --init zsh)" to initialize, it will create a _zlua() function and alias z to it, so there is no need to rename z.lua to z.
The formal bin name z.lua is better accordant with other distros.

Motivation for this change

Better accordant with official and other distros.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@holymonson @marsam
z-lua: reveal bin name z to z.lua
8f64cae 
According to document, user should call `eval "$(z.lua --init zsh)"` to initialize, it will create a _zlua() function and alias z to it, so there is no need to rename z.lua to z.
The formal bin name z.lua is better accordant with other distros.
@ofborg ofborg bot requested a review from marsam August 23, 2020 11:35
@KamilaBorowska
Copy link
Member

KamilaBorowska commented Aug 23, 2020 •
edited

This seems like a breaking change, especially considering this package existed for quite a while. It makes sense, but I think z should still exist (maybe as a symlink to z.lua).

@marsam marsam merged commit 043683f into NixOS:master Dec 23, 2020
@holymonson holymonson deleted the patch-2 branch January 17, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@holymonson @KamilaBorowska @marsam @Janik-Haag