Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/security/misc: add option unprivilegedUsernsClone #96080

Merged
merged 1 commit into from Aug 26, 2020
Merged

nixos/security/misc: add option unprivilegedUsernsClone #96080

merged 1 commit into from Aug 26, 2020

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Aug 23, 2020

Motivation for this change

Needed to work Podman with hardened profile.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin requested a review from joachifm as a code owner August 23, 2020 10:24
@joachifm joachifm merged commit 1ad014b into NixOS:master Aug 26, 2020
@Izorkin Izorkin deleted the unprivileged-userns-clone branch August 26, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @joachifm