Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] rescuetime: 2.16.2.1 -> 2.16.3.1 #95964

Merged
merged 1 commit into from Sep 8, 2020
Merged

[20.03] rescuetime: 2.16.2.1 -> 2.16.3.1 #95964

merged 1 commit into from Sep 8, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

rescuetime currently fails to build in 20.03 due to an incorrect hash. This change fixes that by (1) pointing to a particular version, rather than the most recent version, (2) updating the hashes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@steshaw @danieldk
rescuetime: 2.16.2.1 -> 2.16.3.1
4a6bf88 
(cherry picked from commit 4315835)
@danieldk danieldk mentioned this pull request Aug 22, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from cstrahan August 22, 2020 07:01
@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020

Builds and runs on NixOS. Did not test function (requires account).

@worldofpeace worldofpeace merged commit 50c60af into NixOS:release-20.03 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @tomberek @worldofpeace @steshaw