Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write_stylus: refactor (sha256) #96029

Merged
merged 1 commit into from Aug 24, 2020
Merged

write_stylus: refactor (sha256) #96029

merged 1 commit into from Aug 24, 2020

Conversation

oyren
Copy link
Contributor

@oyren oyren commented Aug 22, 2020

Motivation for this change

Checksum updated and #95963 fixed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oyren oyren requested a review from danieldk August 23, 2020 16:12
@oyren oyren requested a review from danieldk August 23, 2020 19:44
danieldk
danieldk approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot LGTM.

Result of nixpkgs-review pr 96029 1

1 package built:
- write_stylus

@danieldk danieldk merged commit b1499c3 into NixOS:master Aug 24, 2020
@styluslabs
Copy link

Sorry for the trouble - going forward I will release updates under a different filename.

@oyren oyren deleted the write_stylus_sha256 branch August 24, 2020 08:41
@danieldk
Copy link
Contributor

Sorry for the trouble - going forward I will release updates under a different filename.

Awesome, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oyren @styluslabs @danieldk