[20.03] nghttp2: add patch for CVE-2020-11080 #95990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2020-11080
I clearly haven't tried a full rebuild, but I've rebuilt some key packages with this on linux & macos 10.14.
Justification for including patch in-tree:
fetchpatch
has a cyclical dependency withnghttp2
viacurl
, so it won't work without some heavy hackery.The patches in full modify
Makefile.am
andCMakeLists.txt
, which triggers the build process to want to re-runautomake
.automake
itself has cyclical dependencies viacurl
, so we can't provide it here. These sections are non-vital as they're only used to build api documentation.fetchpatch
has a cyclical dependency withnghttp2
viacurl
, so it won't work without some heavy hackery.This is only for a dead-end stable branch and adding this doesn't mean we're going to be carrying this patch around forever.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)