Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pandas: fix for darwin #95992

Merged
merged 2 commits into from Aug 23, 2020
Merged

pythonPackages.pandas: fix for darwin #95992

merged 2 commits into from Aug 23, 2020

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Aug 22, 2020

Motivation for this change

The build failed because -Werror causes clang to complain about -fno-strict-overflow.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Aug 22, 2020
@ofborg ofborg bot requested review from 7c6f434c and knedlsepp August 22, 2020 15:18
@veprbl
Copy link
Member

veprbl commented Aug 22, 2020

cc #39687

@tobim @veprbl
pythonPackages.pandas: fix build with clang
3ccc512 
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
@veprbl
Copy link
Member

veprbl commented Aug 23, 2020

@GrahamcOfBorg build python3Packages.pandas

@veprbl veprbl merged commit 5be356a into NixOS:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobim @veprbl