Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wofi: do not follow symlinks in PATH #95984

Merged
merged 1 commit into from Aug 22, 2020
Merged

wofi: do not follow symlinks in PATH #95984

merged 1 commit into from Aug 22, 2020

Conversation

gebner
Copy link
Member

@gebner gebner commented Aug 22, 2020

Motivation for this change

wofi resolves the symlink in /run/current-system/sw/bin and the resolved binary paths are stored in ~/.cache/wofi-run:

3 /nix/store/i10xnplpxdi9iyydzgkka079n61rvl5m-system-path/bin/firefox

This has the (security-related) effect that if you run firefox once, then wofi will always run that version from then on. Even if you upgraded the system.

Reported upstream:
https://todo.sr.ht/~scoopta/wofi/121

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from a user August 22, 2020 12:23
@ghost
Copy link

ghost commented Aug 22, 2020

Thank you, it works correctly. Is the patch available from SourceHut directly ? If yes, we could use fetchpatch instead of mirroring it locally.

@gebner
Copy link
Member Author

gebner commented Aug 22, 2020

No, because I wasn't sure why it resolved the symlinks at all. According to hg blame, this was related to an issue where there were duplicate entries in PATH that resolved to the same directory. Therefore I didn't post a patch.

@gebner gebner merged commit 9562573 into NixOS:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gebner