Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glib: fixup musl support #96018

Closed
wants to merge 1 commit into from
Closed

glib: fixup musl support #96018

wants to merge 1 commit into from

Conversation

baloo
Copy link
Member

@baloo baloo commented Aug 22, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@baloo
glib: fixup musl support
ef91d18 
Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
@baloo baloo force-pushed the baloo/glib/static-compilation branch from 87bb0fd to ef91d18 Compare August 22, 2020 17:35
jtojnar
jtojnar reviewed Aug 22, 2020
View reviewed changes
pkgs/development/libraries/glib/default.nix
Comment on lines +63 to +65
./fixup-musl-error.patch
./musl_flags_to_string.patch
./optional-deps.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do these patches come from? Were they submitted upstream? Can they be fetched from there?

@baloo baloo closed this Aug 22, 2020
@baloo
Copy link
Member Author

baloo commented Aug 22, 2020

I build those patches, and I'm too lazy to submit them upstream. I'll just close this one.

@baloo baloo deleted the baloo/glib/static-compilation branch August 22, 2020 21:33
@jtojnar
Copy link
Contributor

jtojnar commented Aug 22, 2020

It is not strictly necessary to upstream all patches, just strongly recommended. But we can probably keep it in Nixpkgs if they are documented so that someone could try to upstream them in the future.

@baloo
Copy link
Member Author

baloo commented Aug 22, 2020

Yeah, I actually fixed this one a couple month back, and I do not need it.
It'll stay in github history, should someone need it and want to throw some work to fix that. I have of couple other issue that has an higher priorities than this one for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baloo @jtojnar