Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsepol: fixup static compilation #96015

Closed
wants to merge 1 commit into from

Conversation

baloo
Copy link
Member

@baloo baloo commented Aug 22, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Arthur Gautier <baloo@superbaloo.net>
];

NIX_CFLAGS_COMPILE = "-Wno-error";

patches = stdenv.lib.optional stdenv.hostPlatform.isMusl [
./static.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this patch come from? Was it submitted upstream? Can it be fetched from there?

@baloo baloo closed this Aug 22, 2020
@baloo baloo deleted the baloo/libsepol/static branch August 22, 2020 21:44
@expipiplus1
Copy link
Contributor

@baloo, why was this closed? Seems like a useful addition!

@baloo
Copy link
Member Author

baloo commented Nov 9, 2020

Turned out I did not need libsepol in my build, and I fixing it upstream was more work than what I was willing to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants