lvm2: support static compilation #96014
Conversation
baloo
changed the title
baloo
force-pushed
the
baloo/lvm2/static-compilation
branch
from
13321be
to
5b6c5ba
Compare
| @@ -84,6 +85,7 @@ stdenv.mkDerivation rec { | |||
| url = "https://git.alpinelinux.org/aports/plain/main/lvm2/mlockall-default-config.patch?h=3.7-stable&id=31bd4a8c2dc00ae79a821f6fe0ad2f23e1534f50"; | |||
| sha256 = "1ivbj3sphgf8n1ykfiv5rbw7s8dgnj5jcr9jl2v8cwf28lkacw5l"; | |||
| }) | |||
| ./no-dynamic.patch | |||
There was a problem hiding this comment.
Where does this patch come from? Was it submitted upstream? Can it be fetched from there?
There was a problem hiding this comment.
I rewrote the patch to a version I'm much more confident sending upstream. I sent the patch upstream (lvm-devel@ mailiing list but my patch does not show up in the archive (yet?)), I'll keep an eye on it and update according to comments made by upstream.
There was a problem hiding this comment.
baloo
force-pushed
the
baloo/lvm2/static-compilation
branch
from
5b6c5ba
to
3860c52
Compare
baloo
force-pushed
the
baloo/lvm2/static-compilation
branch
from
3860c52
to
bb9c1e5
Compare
| @@ -31,11 +31,12 @@ stdenv.mkDerivation rec { | |||
| "--enable-pkgconfig" | |||
| "--with-default-locking-dir=/run/lock/lvm" | |||
| "--with-default-run-dir=/run/lvm" | |||
| "--with-systemdsystemunitdir=${placeholder "out"}/lib/systemd/system" | |||
There was a problem hiding this comment.
Why was this moved to udev != null. Is that "codepath" even used anywhere in nixpkgs?
There was a problem hiding this comment.
I use it on static builds (one I use in initrd, to save space). Building udev/systemd static is ... quite challenging :) (or all the dependencies it pulls)
| return 14; | ||
| close (fd); | ||
| + free (data); | ||
| + free (data3); |
There was a problem hiding this comment.
Does this mean there was a memory leak upstream? Not sure I like this being silently in the middle of allow-static-build patch…
There was a problem hiding this comment.
configure (the output from autoconf) is commited in the repository. I ran autoconf, with a slightly more recent version than last maintainer of that file did (more than a year ago).
It looks like it's code that tests features from the environment to detect them, as autoconf usually does. This looks like fixes further upstream in autoconf.
Just like the runstate parameter additions, I think they can safely be ignored.
There was a problem hiding this comment.
Well, memory leak in a temporary configure executable 🤷
Motivation for this change
Fixup compilation of lvm2 on musl.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)