Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ocamlgraph: make GTK support optional #95976

Merged
merged 1 commit into from Aug 23, 2020
Merged

ocamlPackages.ocamlgraph: make GTK support optional #95976

merged 1 commit into from Aug 23, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Aug 22, 2020

Motivation for this change

#95849 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
ocamlPackages.ocamlgraph: make GTK support optional
5811b7b 
When `gtkSupport` is true, additional components are built:

 - a module to render a graph on a GTK2 canvas
 - two GTK-based programs: a graph viewer and a graph editor.

The default is to have `gtkSupport` as it is used in e.g., Frama-C.
@vbgl
Copy link
Contributor Author

vbgl commented Aug 22, 2020

@GrahamcOfBorg build framac coqPackages.dpdgraph

cc @marsam

@vbgl vbgl merged commit e3c2934 into NixOS:master Aug 23, 2020
@vbgl vbgl deleted the ocaml-ocamlgraph-clean branch August 23, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @marsam