Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Road type convert tool incorrectly updates infrastructure totals for: bridges, tunnels, depots, road stops #8297

Closed
JGRennison opened this issue Aug 22, 2020 · 0 comments
Closed

Road type convert tool incorrectly updates infrastructure totals for: bridges, tunnels, depots, road stops #8297

JGRennison opened this issue Aug 22, 2020 · 0 comments

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

Since: c02ef3e

Expected result

Infrastructure totals are correctly updated when using the road type convert tool

Actual result

Infrastructure totals are not correctly updated when using the road type convert tool
Bridges, tunnels, depots: Half of the correct value is subtracted from the old road type and added to the new road type
Road stops (bay and drive-through): Infrastructure totals are not updated at all

This can cause multiplayer desyncs, money exploits (see #7625), etc.

Steps to reproduce

Same as #7625, except for bridges, tunnels, depots, road stops (bay and drive-through)
UnsuspiciousGooball pushed a commit to UnsuspiciousGooball/OpenTTD that referenced this issue Dec 27, 2020
Fix OpenTTD#8297: Infrastructure counters for road tunnels, bridges, …
8b92988 
…depots and bus and truck stops after road type conversion are now correct

The previous fix 887e948 only worked for roads and failed to consider a multiplier used for the infrastructure totals for tunnels/bridges.
Also, depots and bus/truck stops are counted as 2 road pieces on creation but were only counted as 1 road piece on conversion because the function DiagDirToRoadBits() was used, which only ever returns single-piece road segments.
@UnsuspiciousGooball UnsuspiciousGooball mentioned this issue Dec 27, 2020
Merged
UnsuspiciousGooball pushed a commit to UnsuspiciousGooball/OpenTTD that referenced this issue Dec 28, 2020
Fix OpenTTD#8297: Infrastructure counters for road tunnels, bridges, …
d261993 
…depots and bus and truck stops after road type conversion are now correct

The previous fix 887e948 only worked for roads and failed to consider a multiplier used for the infrastructure totals for tunnels/bridges.
Also, depots and bus/truck stops are counted as 2 road pieces on creation but were only counted as 1 road piece on conversion because the function DiagDirToRoadBits() was used, which only ever returns single-piece road segments.
UnsuspiciousGooball pushed a commit to UnsuspiciousGooball/OpenTTD that referenced this issue Dec 28, 2020
Fix OpenTTD#8297: Infrastructure counters for road tunnels, bridges, …
7e548fb 
…depots and bus and truck stops after road type conversion are now correct

The previous fix 887e948 only worked for roads and failed to consider a multiplier used for the infrastructure totals for tunnels/bridges.
Also, depots and bus/truck stops are counted as 2 road pieces on creation but were only counted as 1 road piece on conversion because the function DiagDirToRoadBits() was used, which only ever returns single-piece road segments.
@James103 James103 mentioned this issue Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JGRennison