Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easyrsa: 3.0.0 -> 3.0.8 #96047

Merged
merged 1 commit into from Dec 6, 2020
Merged

easyrsa: 3.0.0 -> 3.0.8 #96047

merged 1 commit into from Dec 6, 2020

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Aug 23, 2020 •
edited

Motivation for this change

Getting latest version of easy-rsa. Slightly different NixOS compatibility patch required.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@numinit numinit changed the title easyrsa: Update to 3.0.7 easyrsa: 3.0.0 -> 3.0.7 Aug 23, 2020
@risicle
Copy link
Contributor

risicle commented Aug 31, 2020

Builds & runs, macos 10.14 too.

@numinit numinit removed the request for review from offlinehacker September 2, 2020 01:39
@tomberek
Copy link
Contributor

tomberek commented Sep 6, 2020

builds, runs, functions as expected on NixOS.

@numinit numinit changed the title easyrsa: 3.0.0 -> 3.0.7 easyrsa: 3.0.0 -> 3.0.8 Sep 19, 2020
@numinit
Copy link
Contributor Author

numinit commented Sep 19, 2020

Revised to update easy-rsa to 3.0.8. No changes to compatibility patch required.

@ofborg ofborg bot requested a review from offlinehacker September 19, 2020 23:02
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/393

@markuskowa
Copy link
Member

@GrahamcOfBorg build easyrsa

@markuskowa markuskowa merged commit 30c976b into NixOS:master Dec 6, 2020
@numinit numinit deleted the update-easy-rsa branch December 6, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@risicle risicle risicle approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@numinit @risicle @tomberek @nixos-discourse @markuskowa