thin-provisioning-tools: 0.7.6 -> 0.9.0 #96010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcunat
approved these changes
Sep 1, 2020
Ericson2314
reviewed
Feb 27, 2021
| extraPrefix = ""; # empty means add 'a/' and 'b/' | ||
| }) | ||
| ]; | ||
| buildInputs = [ expat libaio boost binutils ]; |
There was a problem hiding this comment.
Why is binutils needed? This makes this package target-sensative, i.e. varying the target platform while keeping build and host constant changes the hash.
There was a problem hiding this comment.
If I remember correctly, that was to get a static build of it. But I guess I should have done something like:
buildInputs = [ expat libaio boost ] ++ lib.optional stdenv.hostPlatform.isStatic binutils;
instead.
I'll try to reproduce and get a PR in to fix that.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
thin-provisinoning-tool 0.9.0 includes some fixes regarding static builds.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)