Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.containers-reloadable: fixes #96070

Merged
merged 3 commits into from Aug 23, 2020
Merged

nixosTests.containers-reloadable: fixes #96070

merged 3 commits into from Aug 23, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 23, 2020

Motivation for this change

This exposes the test at nixosTests.containers-reloadable, and fixes typos/outdated references.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from tfc and danbst August 23, 2020 09:04
@flokli
Copy link
Contributor Author

flokli commented Aug 23, 2020

@GrahamcOfBorg test containers-reloadable

@tfc tfc merged commit 54cb0ed into NixOS:master Aug 23, 2020
@flokli flokli deleted the containers-reloadable-fixes branch August 23, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@tfc tfc Awaiting requested review from tfc

@danbst danbst Awaiting requested review from danbst

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @rnhmjoj @tfc