Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.hocker-fetchdocker #96076

Merged
merged 2 commits into from Aug 24, 2020
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 23, 2020

This ports over the hocker-fetchdocker VM test to the python tooling.
The test itself seems broken without internet access, so I marked it as broken for now.

I opened #96075 to unbreak the test.

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This test tries to download from the official docker registry. I don't
know how this could ever work, but let's mark it as broken for now.
@flokli flokli force-pushed the port-test-hocker-fetchdocker branch from 6b2e748 to aa55b14 Compare August 23, 2020 20:42
@tfc tfc merged commit 45dd255 into NixOS:master Aug 24, 2020
@flokli flokli deleted the port-test-hocker-fetchdocker branch August 27, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants