Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.swspotify: init at 1.2.1, swaglyrics: init at 1.2.2 #96051

Merged
merged 2 commits into from Oct 11, 2020
Merged

python3Packages.swspotify: init at 1.2.1, swaglyrics: init at 1.2.2 #96051

merged 2 commits into from Oct 11, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Aug 23, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben
Copy link
Member Author

siraben commented Aug 23, 2020

@GrahamcOfBorg build swaglyrics

@siraben siraben marked this pull request as draft August 23, 2020 03:38
@siraben
Copy link
Member Author

siraben commented Aug 23, 2020

Converted to draft since running the executable fails due to the following error. Package author has been contacted and I'll await new release on PyPI.

Updating unsupported.txt from server.
Traceback (most recent call last):
  File "/nix/store/7ggvgdx5v6nqqhf4nj197s5df2hmbi02-swaglyrics-1.2.0/bin/.swaglyrics-wrapped", line 9, in <module>
    sys.exit(main())
  File "/nix/store/7ggvgdx5v6nqqhf4nj197s5df2hmbi02-swaglyrics-1.2.0/lib/python3.8/site-packages/swaglyrics/__main__.py", line 119, in main
    unsupported_precheck(args.update_check)
  File "/nix/store/7ggvgdx5v6nqqhf4nj197s5df2hmbi02-swaglyrics-1.2.0/lib/python3.8/site-packages/swaglyrics/__main__.py", line 40, in unsupported_precheck
    with open(unsupported_txt, 'w', encoding='utf-8') as f:
OSError: [Errno 30] Read-only file system: '/nix/store/7ggvgdx5v6nqqhf4nj197s5df2hmbi02-swaglyrics-1.2.0/lib/python3.8/site-packages/swaglyrics/unsupported.txt'

@siraben siraben marked this pull request as ready for review August 23, 2020 05:26
@siraben
Copy link
Member Author

siraben commented Aug 23, 2020

@GrahamcOfBorg build swaglyrics

@siraben siraben changed the title swaglyrics: init at 1.2.0 swaglyrics: init at 1.2.2 Aug 23, 2020
@siraben siraben changed the title swaglyrics: init at 1.2.2 swaglyrics: init at 1.2.2, swspotify: init at 1.2.1, requests: 2.23.0 -> 2.24.0 Aug 23, 2020
@siraben siraben force-pushed the swaglyrics-init branch 2 times, most recently from 93097b4 to 5772929 Compare August 24, 2020 01:16
@siraben siraben requested a review from jonringer August 24, 2020 01:16
@siraben siraben changed the title swaglyrics: init at 1.2.2, swspotify: init at 1.2.1, requests: 2.23.0 -> 2.24.0 swaglyrics: init at 1.2.2, swspotify: init at 1.2.1 Aug 24, 2020
@siraben
Copy link
Member Author

siraben commented Aug 24, 2020

@GrahamcOfBorg build swaglyrics

@siraben
Copy link
Member Author

siraben commented Sep 6, 2020

Ok, rebased on latest master. Enabling tests still causes the build to fail, though.

@jonringer
Copy link
Contributor

if they still have unit tests that run within the sandbox, they should be enabled as much as possible. If all the tests aren't able to run, then there should be a comment stating that they aren't able to be ran within a sandbox.

@siraben
Copy link
Member Author

siraben commented Sep 14, 2020 •
edited

I think I realize what's happening now by testing with nix-shell after unpackPhase, there doesn't seem to be a tests folder, is this due to the tests not being uploaded to PyPI?

@siraben
Copy link
Member Author

siraben commented Oct 5, 2020

@jonringer I've updated the derivation to disable tests that require network access, need to do the same with the python3Packages.swspotify package.

@siraben siraben force-pushed the swaglyrics-init branch 3 times, most recently from 15b7693 to 0eae2c6 Compare October 6, 2020 03:27
jonringer
jonringer reviewed Oct 6, 2020
View reviewed changes
pkgs/tools/misc/swaglyrics/skip_network_test.patch Outdated
Comment on lines 4 to 9
+++ b/tests/test_tab.py
@@ -4,6 +4,7 @@ Contains unit tests for tab.py
import flask_testing
from SwSpotify import SpotifyNotRunning
from mock import patch
+import unittest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch should be unnecessary with my other comment

@siraben
Copy link
Member Author

siraben commented Oct 10, 2020

Just tested on NixOS, tests seem to pass and package runs as expected.

jonringer
jonringer approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96051 1

3 packages built:
  • python37Packages.swspotify
  • python38Packages.swspotify
  • swaglyrics

@jonringer jonringer merged commit 3204e87 into NixOS:master Oct 11, 2020
@siraben siraben deleted the swaglyrics-init branch October 11, 2020 05:55
@siraben siraben restored the swaglyrics-init branch December 4, 2020 12:12
@siraben siraben deleted the swaglyrics-init branch November 3, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @jonringer