New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: pending-{set,clear} #96056
Conversation
name: "set pending status" | ||
|
||
on: | ||
pull_request_target: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target
This event is similar to
pull_request
, except that it runs in the context of the base repository of the pull request, rather than in the merge commit. This means that you can more safely make your secrets available to the workflows triggered by the pull request, because only workflows defined in the commit on the base repository are run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me if it works!
Guess we need a token, it would need to have @GrahamcOfBorg would probably be the easiest to use but not sure that anyone else has the keys to it? @cole-h Do you know? |
What scope does a token has when it builds on the master branch? |
Seems that the default GITHUB_TOKEN is sufficient for this, sorry for the noise. |
Add actions to set a pending status that is then cleared by an ofborg event.
Initial dicussion in NixOS/ofborg#527
Tested in a personal repo with travis.
cc @Mic92