Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia_x11_beta: 450.66 -> 440.66.14 #96057

Closed
wants to merge 2 commits into from
Closed

nvidia_x11_beta: 450.66 -> 440.66.14 #96057

wants to merge 2 commits into from

Conversation

expipiplus1
Copy link
Contributor

This is fetched from a different URL, so allow passing that explicitly.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from baracoder August 23, 2020 06:41
@expipiplus1 expipiplus1 force-pushed the joe-nvidia-beta branch 2 times, most recently from c8bbc01 to 806f686 Compare August 23, 2020 07:29
@expipiplus1
Copy link
Contributor Author

Sorry, this makes no sense, it's a driver downgrade! I rebased it without looking!

@expipiplus1 expipiplus1 deleted the joe-nvidia-beta branch August 26, 2020 11:16
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Aug 29, 2020 •
edited

Actually, I shouldn't have closed this, 440.66 has extensions which 450.66 lacks such as VK_KHR_ray_tracing so it's not strictly a downgrade.

@expipiplus1 expipiplus1 reopened this Aug 29, 2020
@expipiplus1
nvidia_x11_beta: 450.66 -> 440.66.14
cbf2990 
This is fetched from a different URL, so allow passing that explicitly.
@expipiplus1
Copy link
Contributor Author

The custom URL is no longer necessary after the bump to 450.51, I left it in anyway but happy to remove.

@expipiplus1
Copy link
Contributor Author

Thanks for approving @baracoder. Is it possible to get this merged?

@Lassulus
Copy link
Member

@eadwu pinging you here cause you changed the beta attribute to stable.

@eadwu
Copy link
Member

eadwu commented Sep 10, 2020

Is this the vulkan driver? I'm not sure how that is handled here, generally I have never seen any version bumps to the vulkan version here (I believe).

@eadwu
Copy link
Member

eadwu commented Sep 10, 2020

Wait I'm not sure what's the point of this, why do you want 450.51?

@eadwu
Copy link
Member

eadwu commented Sep 10, 2020

Not sure why you would want to downgrade.

Diffed 450.57 and 450.51 release notes and I don't see any differences from 450.51 content besides additions.

@eadwu eadwu closed this Sep 10, 2020
@expipiplus1
Copy link
Contributor Author

I think I may have made a mistake in using 450.51 as this wasn't a beta driver (not sure how I got that confused), thanks for catching that, @eadwu

I've bumped my branch to 450.56.11. This version does contain extensions which 450.57 doesn't.

One significant wart is that there aren't releases of nvidia-persistenced and nvidia-settings for the beta releases (issues raised: NVIDIA/nvidia-persistenced#8 NVIDIA/nvidia-settings#52) so I've had to add some functionality to use a different version of these than the driver; this is certainly not a configuration supported by Nvidia. However it seems to be working for me using a close but not exact version for these tools :/

@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Sep 11, 2020 •
edited

Ah, I'm unable to reopen this PR as I forced pushed to my branch. The diff is here expipiplus1@31f1e6a. If the weird version mix is acceptable for the beta driver then I can create a new PR

@eadwu
Copy link
Member

eadwu commented Sep 11, 2020

It's probably better to include it as vulkan_beta or something similar, if I'm not mistaken, I believe beta just refers to the short-lived branch for nvidia while the vulkan beta can be considered another branch.

Keep in mind you'll probably need to update the module nvidia.nix to include something like nvidiaVulkan that references nvidia_x11.vulkan_beta.

@expipiplus1 expipiplus1 mentioned this pull request Sep 13, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baracoder baracoder baracoder approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@expipiplus1 @Lassulus @eadwu @baracoder