Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/jellyfin: document stateVersion 20.09 in release notes #95987

Merged
merged 1 commit into from Sep 9, 2020
Merged

nixos/jellyfin: document stateVersion 20.09 in release notes #95987

merged 1 commit into from Sep 9, 2020
+10 −0

Conversation

minijackson
Copy link
Member

Motivation for this change

Document changes made in #93654 in release notes.

cc @Church-

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@minijackson
Copy link
Member Author

summoning @jonringer as release manager? Sorry if it's not the right way to do it...

@worldofpeace
Copy link
Contributor

Hi @minijackson this looks good. Can you rebase and I can merge this? We've also branched 20.09 since Sep 7th, so we'll need a backport as well.

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 8, 2020
@minijackson minijackson force-pushed the jellyfin-stateVersion-20.09-releaseNotes branch from 9e89de9 to ad48050 Compare September 9, 2020 07:47
@minijackson
Copy link
Member Author

@worldofpeace done, thanks!

@worldofpeace worldofpeace merged commit f03c63e into NixOS:master Sep 9, 2020
@worldofpeace
Copy link
Contributor

Okay, awaiting your backport now 👍

@minijackson minijackson mentioned this pull request Sep 9, 2020
Merged
@minijackson minijackson deleted the jellyfin-stateVersion-20.09-releaseNotes branch September 9, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minijackson @worldofpeace @jonringer